Hi all,
Every now and then I come across a few
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/core/manifest/ClassManifest.php#L279-L280>
bits
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/core/manifest/ConfigManifest.php#L431-L432>
of
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/model/DataList.php#L377-L382>
core
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/model/DataList.php#L393-L405>
code that don’t match our coding conventions
<http://doc.silverstripe.org/framework/en/trunk/misc/coding-conventions>.
Would the core team accept (or indeed want) pull requests to fix this sort
of stuff or should we leave this stuff until someone amends something in a
class/method? I’m only talking about minor changes (indentation,
whitespace, line length etc) as opposed to deprecating method names that
don’t match conventions, for example.
If these sort of pull requests would be welcome:
- Would it be better to target a few files/classes per pull request (or
perhaps a folder), or one file per pull request?
- Which branch should these be opened against? I would assume 3.1, but
will these sort of changes make merging upstream more difficult for core
contributors?
If these sort of pull requests would be more of an annoyance than an
improvement:
- When should we tidy this stuff up? Only touch a method you're editing,
or tidy up a whole class if you're editing one method?
Loz
Every now and then I come across a few
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/core/manifest/ClassManifest.php#L279-L280>
bits
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/core/manifest/ConfigManifest.php#L431-L432>
of
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/model/DataList.php#L377-L382>
core
<https://github.com/silverstripe/silverstripe-framework/blob/3.1/model/DataList.php#L393-L405>
code that don’t match our coding conventions
<http://doc.silverstripe.org/framework/en/trunk/misc/coding-conventions>.
Would the core team accept (or indeed want) pull requests to fix this sort
of stuff or should we leave this stuff until someone amends something in a
class/method? I’m only talking about minor changes (indentation,
whitespace, line length etc) as opposed to deprecating method names that
don’t match conventions, for example.
If these sort of pull requests would be welcome:
- Would it be better to target a few files/classes per pull request (or
perhaps a folder), or one file per pull request?
- Which branch should these be opened against? I would assume 3.1, but
will these sort of changes make merging upstream more difficult for core
contributors?
If these sort of pull requests would be more of an annoyance than an
improvement:
- When should we tidy this stuff up? Only touch a method you're editing,
or tidy up a whole class if you're editing one method?
Loz